-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PACKAGE_VERSION & __DATE__ with release tag #9
Conversation
The problem I have with this is that it's quite messy, and the only purpose is to have a different version string from the one we have right now. Also, this would be the only tool with this version string, which is strange. Which version of |
I'd imagine that if this PR were merged then the other tools should also be updated accordingly, since like you say, it would be inconsistent otherwise. As for git... $ git --version
git version 2.46.1 I think it may be caused by git not storing dates for lightweight tags; from
|
Rename the commit to say |
Updated. |
Hmmm this doesn't seem to be working fine for me:
What do you get? That tag is really old, there are a bunch of tags after that one. However, according to SemVer, they are "older" versions, so that may be the reason. |
This is what I get:
The syntax I just pushed a commit that should fix this. |
Ok, I see. Thanks for the investigation! |
Relevant: blocksds/sdk#196
For some reason,
git describe
seems to return the oldest of all the lightweight tags for any given commit on my machine, so commit8113974d7f975e349c0e8f7d11b5c1e16e77a496
appears asv1.4.0-blocks
instead ofv1.5.0-blocks
because they are the same commit. This could be fixed by using git's annotated tags, or partially fixed by havingSDK_VERSION
additionally defined in the top-level SDK Makefile since the SDK always has commits between versions.